launch.c: replaced "/c/windows/explorer.exe" with just "explorer.exe"#1466
Open
tobybear wants to merge 1 commit intojart:masterfrom
Open
launch.c: replaced "/c/windows/explorer.exe" with just "explorer.exe"#1466tobybear wants to merge 1 commit intojart:masterfrom
tobybear wants to merge 1 commit intojart:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In launch.c, when run under Windows, the following command is launched:
However the Windows main folder is not always located in C:\Windows, it can be on a different drive and (less common) also have different folder name, so a call to "/c/windows/explorer.exe" might fail. But since explorer.exe on Windows is in the global path, the posix_spawnp call does not need an absolute path anyway and "explorer.exe" is enough and more universal.