Initial Oauth2 implementation #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondilworth56
added
enhancement
jasondilworth56
force-pushed
the
main
branch
from
65899b2 to
bc7c245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upcoming iRacing Oauth2 implementation, I find it useful to bring it into this project in a minimal fashion.
For now the fact that refresh tokens can only be used once means that I'm reticent to have that refresh happening inside this client – that could end in a situation where other consumers of a token find they are invalidated by a refresh happening in iracingdataapi. For that reason we leave that management outside of this project.