Skip to content

fix: by smoke_wheel#155

Merged
jasoneri merged 1 commit into
GUIfrom
2.9-dev
Mar 7, 2026
Merged

fix: by smoke_wheel#155
jasoneri merged 1 commit into
GUIfrom
2.9-dev

Conversation

@jasoneri
Copy link
Copy Markdown
Owner

@jasoneri jasoneri commented Mar 7, 2026

Description

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

Summary by Sourcery

更新用于索引选择的 CLI 帮助文本,并移除计划任务测试的 GitHub Actions 工作流。

增强功能:

  • 通过参考更新后的 GUI 工具提示文本,改进 CLI 索引选择的帮助信息。

CI:

  • 移除已过时的计划任务测试 GitHub Actions 工作流配置。
Original summary in English

Summary by Sourcery

Update CLI help text for index selection and remove the scheduled test GitHub Actions workflow.

Enhancements:

  • Improve the CLI index selection help message by referencing the updated GUI tooltip text.

CI:

  • Remove the obsolete scheduled test GitHub Actions workflow configuration.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Mar 7, 2026

审阅者指南(在小型 PR 上折叠)

审阅者指南

更新 crawl_only CLI 帮助文案,为 indexes 参数使用不同的资源字符串,并移除之前用于测试的计划 GitHub Actions 工作流。

文件级变更

变更 详情 文件
调整 CLI 中 indexes 参数的帮助文案,使其引用正确的 GUI 资源字符串。
  • -i/--indexes 参数的帮助文案改为将 res.GUI.Uic.chooseBoxToolTip 转换为字符串。
  • 确保帮助字符串与 GUI 提示气泡(tooltip)资源保持一致。
crawl_only.py
移除之前按计划运行测试的 GitHub Actions 定时工作流。
  • 从代码库中删除 .github/workflows/schedule_test.yml 工作流文件。
.github/workflows/schedule_test.yml

技巧和命令

与 Sourcery 交互

  • 触发新审阅: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub Issue: 通过回复某条审阅评论,请求 Sourcery 从该评论创建一个 Issue。你也可以在审阅评论下回复 @sourcery-ai issue 来从该评论创建 Issue。
  • 生成 pull request 标题: 在 pull request 标题的任意位置写上 @sourcery-ai,即可在任意时间生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文的任意位置写上 @sourcery-ai summary,即可在你想要的具体位置生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可在任意时间(重新)生成审阅者指南。
  • 一次性解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。如果你已经处理完所有评论且不想再看到它们,这会非常有用。
  • 一次性撤销所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,即可撤销所有现有的 Sourcery 审阅。特别适用于你想从头开始新的审阅流程——别忘了再评论 @sourcery-ai review 来触发新的审阅!

自定义你的体验

访问你的控制面板 以:

  • 启用或禁用诸如 Sourcery 生成的 pull request 摘要、审阅者指南等审阅功能。
  • 更改审阅语言。
  • 添加、移除或编辑自定义审阅指令。
  • 调整其他审阅设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the crawl_only CLI help text to use a different resource string for the indexes argument and removes the scheduled GitHub Actions workflow used for tests.

File-Level Changes

Change Details Files
Adjust CLI help text for the indexes argument to reference the correct GUI resource string.
  • Change the -i/--indexes argument help text to cast res.GUI.Uic.chooseBoxToolTip to string.
  • Ensure the help string is consistent with the GUI tooltip resource.
crawl_only.py
Remove the scheduled GitHub Actions workflow that previously ran tests on a schedule.
  • Delete the .github/workflows/schedule_test.yml workflow file from the repository.
.github/workflows/schedule_test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我给出了一些整体性的反馈:

  • crawl_only.py 中,如果 res.GUI.Uic.chooseBoxToolTip 已经是字符串,那么显式的 str(...) 转换就是不必要的,可以移除以让代码更简洁一些。
  • 这个 PR 完全移除了 schedule_test.yml GitHub Actions 工作流;如果这是有意为之,建议在 PR 描述中添加一个简短说明,方便后续维护者理解为什么禁用了定时任务。
给 AI Agent 的提示
Please address the comments from this code review:

## Overall Comments
- In `crawl_only.py`, if `res.GUI.Uic.chooseBoxToolTip` is already a string, the explicit `str(...)` cast is unnecessary and could be removed to keep the code a bit cleaner.
- The `schedule_test.yml` GitHub Actions workflow is fully removed in this PR; if this is intentional, consider adding a brief explanation in the PR description so future maintainers understand why scheduled runs were disabled.

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English

Hey - I've left some high level feedback:

  • In crawl_only.py, if res.GUI.Uic.chooseBoxToolTip is already a string, the explicit str(...) cast is unnecessary and could be removed to keep the code a bit cleaner.
  • The schedule_test.yml GitHub Actions workflow is fully removed in this PR; if this is intentional, consider adding a brief explanation in the PR description so future maintainers understand why scheduled runs were disabled.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `crawl_only.py`, if `res.GUI.Uic.chooseBoxToolTip` is already a string, the explicit `str(...)` cast is unnecessary and could be removed to keep the code a bit cleaner.
- The `schedule_test.yml` GitHub Actions workflow is fully removed in this PR; if this is intentional, consider adding a brief explanation in the PR description so future maintainers understand why scheduled runs were disabled.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

jasoneri

This comment was marked as duplicate.

@jasoneri
Copy link
Copy Markdown
Owner Author

jasoneri commented Mar 7, 2026

@sourcery-ai review

https://github.com/jasoneri/ComicGUISpider/actions/runs/22802558246/job/66146433997

TypeError: 'TranslationNamespace' object is not callable

Smoke tests failed: cli help

@jasoneri jasoneri merged commit da21f99 into GUI Mar 7, 2026
3 checks passed
jasoneri added a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant