Skip to content

fix: action container env#163

Merged
jasoneri merged 1 commit into
GUIfrom
2.9-dev
Apr 6, 2026
Merged

fix: action container env#163
jasoneri merged 1 commit into
GUIfrom
2.9-dev

Conversation

@jasoneri
Copy link
Copy Markdown
Owner

@jasoneri jasoneri commented Apr 6, 2026

Description

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

Summary by Sourcery

CI:

  • 在发布工作流中添加一个步骤,在执行 smoke test 任务之前安装 Qt 运行时库。
Original summary in English

Summary by Sourcery

CI:

  • Add a step in the release workflow to install Qt runtime libraries prior to executing the smoke test job.

@jasoneri jasoneri merged commit 4f75f20 into GUI Apr 6, 2026
2 checks passed
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 6, 2026

审阅者指南(在小型 PR 上折叠)

审阅者指南

此 PR 更新了发布用的 GitHub Actions 工作流,在运行冒烟测试之前先在发布任务中安装 Qt 运行时库,从而确保基于 Qt 的 wheel 可以在设置 QT_QPA_PLATFORM=offscreen 时以无头模式运行测试。

更新后的发布任务冒烟测试设置时序图

sequenceDiagram
  actor Dev
  participant GitHub as GitHub_Actions
  participant Runner as Release_job_runner
  participant SetupQt as setup_qt_libs_action
  participant SmokeTest as Smoke_test_step

  Dev->>GitHub: Push tag / trigger release workflow
  GitHub->>Runner: Start release job
  Runner->>Runner: Checkout repository
  Runner->>Runner: Set up Python and uv
  Runner->>Runner: Build package (uv build)
  Runner->>SetupQt: Run tlambert03/setup-qt-libs@v1
  SetupQt-->>Runner: Qt runtime libraries installed
  Runner->>SmokeTest: Run smoke test with QT_QPA_PLATFORM=offscreen
  SmokeTest-->>Runner: Test result (pass/fail)
  Runner-->>GitHub: Job status
  GitHub-->>Dev: Workflow result notification
Loading

文件级变更

变更 详情 文件
确保在运行冒烟测试之前,发布工作流中可以使用 Qt 运行时库。
  • 在发布任务中添加一个 GitHub Action 步骤,使用 tlambert03/setup-qt-libs@v1 安装 Qt 运行时库
  • 将 Qt 安装步骤紧接着放在现有的、使用 QT_QPA_PLATFORM=offscreen 运行的冒烟测试步骤之前
.github/workflows/release.yml

提示与命令

与 Sourcery 交互

  • 触发新一轮审查: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 从审查评论生成 GitHub issue: 回复 Sourcery 的审查评论,请其从该评论创建 issue。你也可以在审查评论下回复 @sourcery-ai issue 来从该评论创建 issue。
  • 生成 pull request 标题: 在 pull request 标题的任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文的任意位置写上 @sourcery-ai summary,即可在你想要的位置生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可随时(重新)生成审阅者指南。
  • 一次性解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们,这将非常有用。
  • 一次性忽略所有 Sourcery 审查: 在 pull request 中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审查。尤其适用于你想从头开始一轮新审查的情况——别忘了再评论 @sourcery-ai review 来触发新审查!

自定义你的使用体验

访问你的控制面板 来:

  • 启用或禁用诸如 Sourcery 生成的 pull request 摘要、审阅者指南等审查功能。
  • 更改审查语言。
  • 添加、删除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the release GitHub Actions workflow to install Qt runtime libraries in the release job before running the smoke test, ensuring the Qt-based wheel can be tested headlessly with the QT_QPA_PLATFORM=offscreen setting.

Sequence diagram for updated release job smoke test setup

sequenceDiagram
  actor Dev
  participant GitHub as GitHub_Actions
  participant Runner as Release_job_runner
  participant SetupQt as setup_qt_libs_action
  participant SmokeTest as Smoke_test_step

  Dev->>GitHub: Push tag / trigger release workflow
  GitHub->>Runner: Start release job
  Runner->>Runner: Checkout repository
  Runner->>Runner: Set up Python and uv
  Runner->>Runner: Build package (uv build)
  Runner->>SetupQt: Run tlambert03/setup-qt-libs@v1
  SetupQt-->>Runner: Qt runtime libraries installed
  Runner->>SmokeTest: Run smoke test with QT_QPA_PLATFORM=offscreen
  SmokeTest-->>Runner: Test result (pass/fail)
  Runner-->>GitHub: Job status
  GitHub-->>Dev: Workflow result notification
Loading

File-Level Changes

Change Details Files
Ensure Qt runtime libraries are available in the release workflow before running the smoke test.
  • Add a GitHub Action step that installs Qt runtime libraries using tlambert03/setup-qt-libs@v1 in the release job
  • Place the Qt installation step immediately before the existing smoke test step that runs with QT_QPA_PLATFORM=offscreen
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好——我已经审查了你的改动,看起来非常棒!


Sourcery 对开源项目是免费的——如果你喜欢我们的审查,请考虑分享给更多人 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的审查。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant