codecov/v8 - #307
Closed
jasonish wants to merge 3 commits into
Closed
Conversation
This reverts commit f951477. Linking the "suricata" crate with "suricata-ffi" appears to break the Codecov.io support for no obvious reason. Revert this commit until it can be figured out. This commit just reduced duplicated code by having the Suricata crate re-use code from the -ffi crate that was moved there for exposure to library and plugin users. Will need investigation as to why using it breaks Codecov.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "rust/debug: use functions from ffi crate where possible"
This reverts commit f951477.
Linking the "suricata" crate with "suricata-ffi" appears to break the
Codecov.io support for no obvious reason. Revert this commit until it
can be figured out.
This commit just reduced duplicated code by having the Suricata crate
re-use code from the -ffi crate that was moved there for exposure to
library and plugin users. Will need investigation as to why using it
breaks Codecov.
testing: link in suricata-ffi, but don't use