DevOps: Remove Managed Package from release.yml

[jasonsiders]

Closes #135. Stops automated updates to the managed package version; we will issue periodic releases of this package for major/minor versions only, after 4.0.0. Until then, we are locked out of making further changes due to some (unintentionally) breaking changes in 3.7.0; some global subtypes of Cmdt.Repository were removed as part of the refactoring.

We retain the ability to manually create a managed package version by running packaing.yml and setting the package type to "managed".

[claude]

Claude finished @jasonsiders's task —— View job

---

PR Review: Remove Managed Package from release.yml

I've completed my review of this pull request. The changes remove automated managed package creation from the CI/CD workflow while retaining unlocked package automation.

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze the modified release.yml file
• Review changes for code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Review test coverage implications
• Provide comprehensive feedback

Review Summary

Overall Assessment: ✅ APPROVED

This is a clean, well-executed removal of managed package automation from the CI/CD pipeline. The changes are focused, safe, and properly implemented.

Detailed Analysis

📋 Code Quality & Best Practices: ✅ Excellent

• Clean removal of the create-managed-package-version job and all its dependencies
• Proper dependency chain updates: create-unlocked-package-version now only depends on versioning
• Release condition simplified to only check for successful unlocked package creation
• Release body generation properly updated to remove managed package installation instructions
• Maintains consistent YAML formatting and structure

🐛 Potential Bugs/Issues: ✅ None Identified

• All job dependencies correctly updated
• Conditional statements properly simplified in create-release job (.github/workflows/release.yml:101)
• No dangling references to removed managed package variables
• The packaging.yml workflow still supports manual managed package creation via workflow_dispatch with package: managed parameter, preserving the manual capability mentioned in the PR description

⚡ Performance Considerations: ✅ Positive Impact

• Reduced CI/CD execution time: Removes one parallel packaging job, reducing overall workflow duration
• Lower resource consumption: Eliminates Salesforce DevHub API calls for managed package creation
• Faster releases: Simplified dependency chain means releases can complete sooner

🔒 Security Concerns: ✅ None

• No security-sensitive changes
• All existing authentication and permission patterns remain intact
• Secrets usage unchanged in remaining workflows

🧪 Test Coverage: ✅ No Impact

• This change affects only CI/CD automation, not application code
• No test modifications needed since functionality being removed is external packaging automation
• Manual testing capability preserved through packaging.yml workflow

Key Changes Breakdown

1. Removed Job: create-managed-package-version job completely removed (.github/workflows/release.yml:86-96)
2. Updated Dependencies:
   • create-unlocked-package-version.needs simplified from [versioning, create-managed-package-version] to [versioning]
   • create-release.needs simplified from [versioning, create-managed-package-version, create-unlocked-package-version] to [versioning, create-unlocked-package-version]
3. Simplified Conditions: Release creation condition no longer checks for managed package success
4. Updated Release Notes: Removed managed package installation instructions from auto-generated release body

Business Context Alignment

The changes align perfectly with the business decision described in the PR:

• Stops problematic automated managed package releases that caused breaking changes in v3.7.0
• Preserves manual managed package creation capability for future major/minor releases
• Maintains automated unlocked package releases for ongoing development

Recommendations

1. ✅ Merge Ready: This PR is safe to merge as-is
2. 📚 Documentation: Consider updating any internal documentation that references the automated managed package workflow
3. 🔄 Future Planning: When ready to resume managed package automation (post-4.0.0), you can easily revert this change

---

[github-actions]

✅ Static Analysis: Check Passed

Analyzed changed files, and found 0 potential violations. 0 meets or exceeds the set severity threshold: Info

⚫ 0 Critical severity violation(s)
🔴 0 High severity violation(s)
🟠 0 Medium severity violation(s)
🟡 0 Low severity violation(s)
⚪ 0 Info severity violation(s)