Skip to content

chore: librdata can now build with conan on MSVC - #6226

Open
shun2wang wants to merge 5 commits into
jasp-stats:developmentfrom
shun2wang:librdata_conan
Open

chore: librdata can now build with conan on MSVC#6226
shun2wang wants to merge 5 commits into
jasp-stats:developmentfrom
shun2wang:librdata_conan

Conversation

@shun2wang

@shun2wang shun2wang commented May 18, 2026

Copy link
Copy Markdown
Contributor

I tried enable msvc build and submit it to conan upstream but they rejected,see: conan-io/conan-center-index#30014 ,so we can use recipe by ourself.

If ReadStat conan version(#6063) on build bot can be fixed, then all of dependencies can be used by Conan.

@shun2wang

shun2wang commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

I also submitted it in msys2 https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-librdata packages, so we can also use it in Rtools if we want.

I prefer Conan cause we can change the source code if we needs (upstream not accept patches or fixes some critical issue slowly).

@tomtomme

Copy link
Copy Markdown
Member

@shun2wang

Copy link
Copy Markdown
Contributor Author

will this solve: https://github.com/jasp-stats/INTERNAL-jasp/issues/2945 ?

nope,it just a build system change. but I had reported on upstream.

@boutinb
boutinb requested a review from JorisGoosen May 20, 2026 09:46
@JorisGoosen

JorisGoosen commented May 26, 2026

Copy link
Copy Markdown
Contributor

Perhaps we could simply fork the project and maintain it within jasp-stats?
If we are using it anyway.
Then we could point conan there. And we need it for other platforms somewhere too right?

@shun2wang

Copy link
Copy Markdown
Contributor Author

Yes, then should also fork my repo https://github.com/shun2wang/librdata-conan-recipe within jasp-stats too.

@JorisGoosen

Copy link
Copy Markdown
Contributor

We wouldnt need the patches or any of that anymore right?

@shun2wang

Copy link
Copy Markdown
Contributor Author

My repo has included a patch to enable build with MSVC, Otherwise cannot build directly using MSVC (because the system-specific header files cannot be found). the upstream librdata didn't have any patch.

@tomtomme

Copy link
Copy Markdown
Member

I accidentaly linked the issue and now cannot remove it... sry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants