chore: librdata can now build with conan on MSVC - #6226
Conversation
|
I also submitted it in msys2 https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-librdata packages, so we can also use it in Rtools if we want. I prefer Conan cause we can change the source code if we needs (upstream not accept patches or fixes some critical issue slowly). |
|
will this solve: https://github.com/jasp-stats/INTERNAL-jasp/issues/2945 ? |
nope,it just a build system change. but I had reported on upstream. |
|
Perhaps we could simply fork the project and maintain it within jasp-stats? |
|
Yes, then should also fork my repo https://github.com/shun2wang/librdata-conan-recipe within jasp-stats too. |
|
We wouldnt need the patches or any of that anymore right? |
|
My repo has included a patch to enable build with MSVC, Otherwise cannot build directly using MSVC (because the system-specific header files cannot be found). the upstream librdata didn't have any patch. |
|
I accidentaly linked the issue and now cannot remove it... sry |
I tried enable msvc build and submit it to conan upstream but they rejected,see: conan-io/conan-center-index#30014 ,so we can use recipe by ourself.
If ReadStat conan version(#6063) on build bot can be fixed, then all of dependencies can be used by Conan.