bugfix: handling locale environment variable to fix i18n and encoding - #6285
Open
shun2wang wants to merge 1 commit into
Open
bugfix: handling locale environment variable to fix i18n and encoding#6285shun2wang wants to merge 1 commit into
shun2wang wants to merge 1 commit into
Conversation
fix locale settings to address encoding and i18n issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: jasp-stats/jasp-issues#4394
Note: I cannot be entirely sure that I can test this situation: jasp-stats/jasp-issues#3867
While I still believe we shouldn't touch any system locale environment variables, as completely placing JASP in any random other language system environment makes it difficult to guarantee that other parts won't have problems, the real fix should probably always start from the data import and display chain.
However, at least set LC_ALL to any value is not the most recommended approach in any case.
see also: https://www.gnu.org/software/gettext/manual/gettext.html#Locale-Environment-Variables