release fixes #258
release fixes #258
Conversation
| bayesianMetaAnalysisAdvanced.priorH1FEValue = 0.5 | ||
| bayesianMetaAnalysisAdvanced.priorH0REValue = 0 | ||
| bayesianMetaAnalysisAdvanced.priorH1REValue = 0 | ||
| } |
There was a problem hiding this comment.
This won't work: the element has no reference to bayesianMetaAnalysisAdvanced.
It's better to make 4 properties
property float priorH0FEValue: 0.25
property float priorH1FEValue: 0.25
property float priorH0REValue: 0.25
property float priorH1REValue: 0.25
That can referred by the parent object. I will make a commit for this.
There was a problem hiding this comment.
Oh I see the logic is already implemented in BayesianMetaAnalysisAdvanced.qml, so all this onCheckedChanged can be removed.
I see one difference in the logic: if the value is constrainedRandom, it has here the same value as averaging (0.25 for every properties), but in the BayesianMetaAnalysisAdvanced, as it will take the default value (0).
There was a problem hiding this comment.
I did not change this however, it was added in the rebase
|
|
||
| ChangeJS | ||
| { | ||
| name: "inferenceOutputScale" |
There was a problem hiding this comment.
Why did you move the name property? I think changeJS should have the name of the option you want to change.
There was a problem hiding this comment.
I also did not change this however, it was added in the rebase. Not sure how that could have happened? I will ask Don tomorrow, maybe he understands.
3 participants
fixes: https://github.com/jasp-stats/jasp-test-release/issues/2789
fixes: https://github.com/jasp-stats/jasp-test-release/issues/2782
fixes: https://github.com/jasp-stats/jasp-test-release/issues/2788