Skip to content

Merge eScience Center and JASP versions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 203 commits into from
Apr 2, 2025

Conversation

PabRod
Copy link
Contributor

@PabRod PabRod commented Mar 19, 2025

Description

We've been working on enriching the template module with some common use cases (performing simple operations over manual inputs, inserting data, creating tabular outputs, creating plots, ...). The goal is to allow future module authors to adapt this template to their needs, softening the learning curve.

The current status is definitely work in progress. Said this, it is a good time to merge what we have done until now. I expect this template to keep growing (and at a faster rate) in the near future.

PabRod and others added 30 commits September 18, 2024 15:31
They were too simplistic
This reverts commit 420c7c5, reversing
changes made to aa2f5a2.
This reverts commit e5495e0, reversing
changes made to b51cf34.
This reverts commit e213321, reversing
changes made to 9c186f6.
This reverts commit 7deb734, reversing
changes made to f9b48f9.
@PabRod
Copy link
Contributor Author

PabRod commented Mar 26, 2025

One tiny nitpicky point I noticed is that QML files are supposed to start with a capital letter. This works, but it is probably better to have the example give the right example ;)

Done!
1837b43

@PabRod
Copy link
Contributor Author

PabRod commented Mar 26, 2025

Dear @JorisGoosen, @vandenman and @FBartos, I addressed all your comments. Let me know if we are good enough to merge. After that, I'll keep working on a develop branch within this repo.

Copy link
Contributor

@FBartos FBartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@JorisGoosen JorisGoosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

At least until we figure out why it is failing and email bombing everybody. Sorry for that
@PabRod
Copy link
Contributor Author

PabRod commented Mar 27, 2025

One last question. Anyone knows why translations.yml is failing (and email-bombing everybody, sorry for that)?

I (temporarily) removed it in the very last commit (bfb36a0).

@JorisGoosen
Copy link
Contributor

@boutinb ?

@PabRod PabRod dismissed vandenman’s stale review April 2, 2025 09:13

Thank you for your useful comments. I implemented all of them, but for some reason GitHub keeps telling me there is still one requested change open (nowhere to be found).

@PabRod
Copy link
Contributor Author

PabRod commented Apr 2, 2025

@JorisGoosen, @RensDofferhoff, this is ready to merge. Stereotypically, I'm going on holiday tomorrow 😅. Feel free to squash and merge now or, if you prefer, wait until I'm back this Tuesday.

@JorisGoosen JorisGoosen merged commit 63c6e12 into jasp-stats:master Apr 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants