-
Notifications
You must be signed in to change notification settings - Fork 13
Merge eScience Center and JASP versions #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
They were too simplistic
new jaspmodule
…plate into dev/template
new myJaspModule module
creating faulty module
Test pull request
Co-authored-by: František Bartoš <[email protected]>
Done! |
Dear @JorisGoosen, @vandenman and @FBartos, I addressed all your comments. Let me know if we are good enough to merge. After that, I'll keep working on a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me
At least until we figure out why it is failing and email bombing everybody. Sorry for that
One last question. Anyone knows why I (temporarily) removed it in the very last commit (bfb36a0). |
@boutinb ? |
Thank you for your useful comments. I implemented all of them, but for some reason GitHub keeps telling me there is still one requested change open (nowhere to be found).
@JorisGoosen, @RensDofferhoff, this is ready to merge. Stereotypically, I'm going on holiday tomorrow 😅. Feel free to squash and merge now or, if you prefer, wait until I'm back this Tuesday. |
Description
We've been working on enriching the template module with some common use cases (performing simple operations over manual inputs, inserting data, creating tabular outputs, creating plots, ...). The goal is to allow future module authors to adapt this template to their needs, softening the learning curve.
The current status is definitely work in progress. Said this, it is a good time to merge what we have done until now. I expect this template to keep growing (and at a faster rate) in the near future.