Skip to content

Configurable persona #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Azelphur wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Configurable persona #472

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8175b8
Configurable persona
Mar 20, 2016
d8ff31d
Silly gedit putting a tab instead of 4 spaces.
Mar 20, 2016
541e7ab
This is what I get for not setting gedit to default to spaces instead…
Mar 20, 2016
fda4e70
Patch unit test
Mar 20, 2016
3ef1b1e
Fixing the typo.
Mar 20, 2016
ec02fbe
Oops, additional S
Azelphur Mar 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions client/vocabcompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,15 @@ def get_keyword_phrases():
if phrase:
phrases.append(phrase)

profile_path = jasperpath.config('profile.yml')
if os.path.exists(profile_path):
with open(profile_path, 'r') as f:
profile = yaml.safe_load(f)
persona = profile.get('persona', 'JASPER').upper()
else:
persona = 'JASPER'

phrases.append(persona)
return phrases


Expand Down
3 changes: 1 addition & 2 deletions static/keyword_phrases
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ FIRST
IN
IS
IT
JASPER
NOW
OF
ON
Expand All @@ -15,4 +14,4 @@ SAY
WHAT
WHICH
WITH
WORK
WORKs

@ThomasDelteil ThomasDelteil Mar 26, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this extra s looks like a missed ctrl+s ?

2 changes: 1 addition & 1 deletion tests/test_vocabcompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def testPhraseExtraction(self):
self.assertEqual(expected_phrases, extracted_phrases)

def testKeywordPhraseExtraction(self):
expected_phrases = ['MOCK']
expected_phrases = ['MOCK', 'JASPER']

with tempfile.TemporaryFile() as f:
# We can't use mock_open here, because it doesn't seem to work
Expand Down