This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Prevent deadlock between WebApplicationImpl and EJBInjectionInterceptor. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @xiaodong-xie, Before we can review your pull request, we need you to sign Oracle Contributor Agreement. More information about contributing to Jersey: https://jersey.java.net/scm.html#/Submitting_Patches_and_Contribute_Code… Regards, |
Contributor
Author
|
Hello, @mgajdos, thanks a lot for replying. I'll sign Oracle Contributor Agreement later this week, should be on Thursday, since right now I'm attending a conference. Have a nice day. |
Contributor
Author
|
Hello, @mgajdos, I've signed, sent the scanner Oracle Contributor Agreement to the specified email address. |
Member
|
merged to the master branch. Thanks! (I have no excuse for the delay.. sorry!) |
Contributor
Author
|
Thanks for merging. :-) |
xiaodong-xie
deleted the
prevent-deadlock-between-WebApplicationImpl-and-EJBInjectionInterceptor
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My colleague and I found a deadlock in Jersey when restarting our production Glassfish-3.1.2.2 server.
The thread dump is like this:
My colleague raised a PR already: #6
But we disagree about the fix. So I create another PR for this issue. :-)
IMHO, I think this is just a viable fix, not the best solution. And since the logic of
WebApplicationImplis quite complex, I chose to fixEJBInjectionInterceptorside of the deadlock. IMHO, theabstractResourceMapinWebApplicationImplis both acting as a lock object to synchronize on ("to ensure that only one instance is created and put to the map" as stated in the comments ofWebApplicationImpl), and also as a protection when invokingWebApplicationImpl::getAbstractResource(Class c). Since in this method, thisabstractResourceMapHashMap could be accessed from different threads, and HashMap itself is not thread safe.What's weird to me in the thread dump is that,
WebApplicationImplshould have initialized itself when taking in request.Thanks a lot for reviewing this.