This repository was archived by the owner on May 28, 2018. It is now read-only.
Fixes error where Netty was not binding properly to a host. #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! We cannot evaluate and accept your proposal without you signing Oracle Contributor Agreement: http://www.oracle.com/technetwork/community/oca-486395.html. Please let us know whether you plan to do that. Best regards, |
|
I just send the OCA. |
|
Any thoughts on this? I'd like to get rid of my custom version of Jersey. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NettyHttpContainerProvider currently ignores the "host" part of the baseUri. This is ok when you want Netty to bind to the main network interface on a server, but it's a problem when there are multiple interfaces, or you want to do loopback testing. For example, you might want to have one instance of Netty bind to 127.0.0.1 and a second one bind to 127.0.0.2 so you can test communications between the two.