This repository was archived by the owner on May 28, 2018. It is now read-only.
JERSEY-3258: Fixed error handling for async client #3545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Alex, thanks for your contribution. In order to keep our code coverage at reasonable level, we do require a test for each bugfix - please updage your PR to include at least some sanity test. Best regards, |
|
Hi! Sure. I added test. Without changed line test will hang forever. |
|
Also added timeout just in case, so test would not hang in CI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
PR addressing JERSEY-3258 bug.
Exceptions thrown while processing response (for example JSON parsing) in async client was not handled properly and was leading client to wait forever.
OCA is signed and sent.