This repository was archived by the owner on May 28, 2018. It is now read-only.
Fixes #3609 #3612
Closed
Fixes #3609 #3612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypnoce
force-pushed
the
jetty_connector_ua
branch
from
5daa86f to
ab03f2a
Compare
|
OCA signed |
hypnoce
force-pushed
the
jetty_connector_ua
branch
from
ab03f2a to
77d7b53
Compare
|
Hi Francois, thanks for sumbitting the pull request. However, we solved the issue via internal commit. Your patch would create a header containing multiple values. The Regards, |
|
Thanks Adam, I agree it will be a multiple value header. Strictly speaking, this is legal as per the http specification. This PR ment to provide a more general solution that does not rely on the fact the jetty has default headers. Regards Francois |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3609 : Combine replicated header in JettyConnector.