Skip to content

Conversation

@NDomergue
Copy link

@NDomergue NDomergue commented Jan 12, 2025

Pull Request Description

Add a button to disable the Drag & Drop feature on the Tracker

Changes Proposed

Add a button to disable the Drag & Drop feature on the Tracker

  • Add an Lock & Unlock icon to icons.ts
  • Add a dragEnabled to the Tracker.ts strore
  • Add a button to Table.svelte in the header to Lock/Unlock the Drag & Drop feature for initiatives.

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

image

image

@NDomergue
Copy link
Author

Ah... I did it on top of the other Pull Request, so it includes it :/

@SondreElg
Copy link
Contributor

I think it's a good feature to have, but the current positioning moves all the other headers to weird locations. I think we're good if you could put the lock as the last header (above the hamburger menus).

Also, if you could cherry pick the changes in this PR to only include the second commit, that'd be great.

@NDomergue
Copy link
Author

Thanks for the input, I'll do that and fix my PR's. I might close this one and create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants