Skip to content

feat: add module-info.java#6

Open
7agustibm wants to merge 1 commit into
mainfrom
module-java
Open

feat: add module-info.java#6
7agustibm wants to merge 1 commit into
mainfrom
module-java

Conversation

@7agustibm
Copy link
Copy Markdown
Collaborator

Add JPMS.

@7agustibm 7agustibm mentioned this pull request Sep 1, 2023
Copy link
Copy Markdown

@apssouza22 apssouza22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @7agustibm it looks good. I am wondering if u were able to create all the automatic modules that comes from the dependencies? if so, would be good to add them here.

When I tried to use it was very painful and I ended up using the graphql-java lib instead.

To offer a good experience it would be good to add those automatic modules declaration as part of the build with maven or Gradle. Thoughts?

Update

It seems that those issues would be fixeed with the module-info.java

My references:
https://github.com/javalin/javalin/pull/1908/files
https://github.com/javalin/javalin-rendering/pull/25/files

@tipsy
Copy link
Copy Markdown
Member

tipsy commented Sep 9, 2023

@7agustibm are you waiting for me? I think should have merging rights?

@7agustibm
Copy link
Copy Markdown
Collaborator Author

Hi @tipsy! Yes, I have merging rights. But I'm doing tests to validate that everything is right and I'm seeing that we use Coroutines and it has some problems with JPMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants