improve data label prefix logic#28
Merged
javerbukh merged 5 commits intoJul 14, 2025
Merged
Conversation
javerbukh
force-pushed
the
enable-loaders-with-tests
branch
from
4141113 to
dac6711
Compare
kecnry
force-pushed
the
image-importer-remove-redundancy
branch
2 times, most recently
from
123ab31 to
b664a3a
Compare
kecnry
force-pushed
the
image-importer-remove-redundancy
branch
2 times, most recently
from
1ac30a0 to
284837d
Compare
kecnry
force-pushed
the
image-importer-remove-redundancy
branch
from
284837d to
99c3736
Compare
kecnry
changed the title
javerbukh
approved these changes
Jul 14, 2025
javerbukh
merged commit 87adff3
into
javerbukh:enable-loaders-with-tests
11 of 18 checks passed
javerbukh
pushed a commit
that referenced
this pull request
Jul 17, 2025
* delete redundant data label prefix logic * avoid double extension * further simplification * fix parent logic * temporary workaround for ImageHDU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some redundancy in handling adding extension to data-labels. Please run tests before merging in case it has unintended consequences 🤞