Fix wcs loading

.github/CODEOWNERS

@@ -4,4 +4,4 @@
 # the repo. Unless a later match takes precedence,
 # they will be requested for
 # review when someone opens a pull request.
-*   @duytnguyendtn @rosteen @javerbukh @pllim @kecnry @bmorris3 @haticekaratay @cshanahan1
+*   @rosteen @javerbukh @kecnry @bmorris3 @haticekaratay @cshanahan1 @gibsongreen @matthewportman

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -91,8 +91,9 @@ body:
         import ipyvuetify; print("ipyvuetify", ipyvuetify.__version__)
         import ipysplitpanes; print("ipysplitpanes", ipysplitpanes.__version__)
         import ipygoldenlayout; print("ipygoldenlayout", ipygoldenlayout.__version__)
+        import ipypopout; print("ipypopout", ipypopout.__version__)
         import jinja2; print("Jinja2", jinja2.__version__)
-        import voila; print("voila", voila.__version__)
+        import solara; print("solara", solara.__version__)
         import vispy; print("vispy", vispy.__version__)
         import sidecar; print("sidecar", sidecar.__version__)
         import jdaviz; print("Jdaviz", jdaviz.__version__)

.github/PULL_REQUEST_TEMPLATE.md

@@ -38,5 +38,5 @@ This checklist is meant to remind the package maintainer(s) who will review this
 - [ ] Are tests added/updated as required? If so, do they follow the [STScI Style Guides](https://github.com/spacetelescope/style-guides)?
 - [ ] Are docs added/updated as required? If so, do they follow the [STScI Style Guides](https://github.com/spacetelescope/style-guides)?
 - [ ] Did the CI pass? If not, are the failures related?
-- [ ] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
+- [ ] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
 - [ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

.github/dependabot.yml

@@ -0,0 +1,15 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "github-actions" # See documentation for possible values
+    directory: ".github/workflows" # Location of package manifests
+    schedule:
+      interval: "monthly"
+    groups:
+      actions:
+        patterns:
+          - "*"

.github/labeler.yml

@@ -1,32 +1,67 @@
 documentation:
-  - docs/**/*
-  - licenses/*
-  - notebooks/**/*
-  - .readthedocs.yaml
-  - README.rst
+- changed-files:
+  - any-glob-to-any-file:
+    - docs/**/*
+    - licenses/*
+    - notebooks/**/*
+    - .mailmap
+    - .readthedocs.yaml
+    - README.rst
+    - LICENSE.rst
+    - '*.md'
+    - '*.cff'
 
 testing:
-  - .github/workflows/*
-  - jdaviz/conftest.py
-  - jdaviz/tests/*
-  - .bandit.yaml
-  - tox.ini
+- changed-files:
+  - any-glob-to-any-file:
+    - .github/workflows/*
+    - jdaviz/conftest.py
+    - jdaviz/tests/*
+    - .bandit.yaml
+    - .flake8
+    - codecov.yml
+    - conftest.py
+    - '**/conftest.py'
+    - tox.ini
 
 embed:
-  - jdaviz/*.vue
-  - share/**/*
+- changed-files:
+  - any-glob-to-any-file:
+    - jdaviz/*.vue
+    - share/**/*
+
+plugin:
+- changed-files:
+  - all-globs-to-any-file:
+    - '**/plugins/**/*'
+    - '!**/plugins/viewers.py'
 
 cubeviz:
-  - jdaviz/configs/cubeviz/**/*
+- changed-files:
+  - any-glob-to-any-file:
+    - jdaviz/configs/cubeviz/**/*
 
 imviz:
-  - jdaviz/configs/imviz/**/*
+- changed-files:
+  - any-glob-to-any-file:
+    - jdaviz/configs/imviz/**/*
 
 mosviz:
-  - jdaviz/configs/mosviz/**/*
+- changed-files:
+  - any-glob-to-any-file:
+    - jdaviz/configs/mosviz/**/*
 
 specviz:
-  - jdaviz/configs/specviz/**/*
+- changed-files:
+  - any-glob-to-any-file:
+    - jdaviz/configs/specviz/**/*
 
 specviz2d:
-  - jdaviz/configs/specviz2d/**/*
+- changed-files:
+  - any-glob-to-any-file:
+    - jdaviz/configs/specviz2d/**/*
+
+rampviz:
+- changed-files:
+  - any-glob-to-any-file:
+    - jdaviz/configs/rampviz/**/*

.github/workflows/changelog_check.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check change log entry
-      uses: scientific-python/action-check-changelogfile@6087eddce1d684b0132be651a4dad97699513113  # 0.2
+      uses: scientific-python/action-check-changelogfile@1fc669db9618167166d5a16c10282044f51805c0  # 0.3
       env:
         CHANGELOG_FILENAME: CHANGES.rst
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/check_milestone.yml

@@ -0,0 +1,34 @@
+name: Check PR milestone
+
+on:
+  # So it cannot be skipped.
+  pull_request_target:
+    types: [opened, synchronize, milestoned, demilestoned]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+  # https://stackoverflow.com/questions/69434370/how-can-i-get-the-latest-pr-data-specifically-milestones-when-running-yaml-jobs
+  milestone_checker:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea  # v7.0.1
+      if: github.repository == 'spacetelescope/jdaviz'
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        script: |
+          const { data } = await github.request("GET /repos/{owner}/{repo}/pulls/{pr}", {
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pr: context.payload.pull_request.number
+            });
+            if (data.milestone) {
+              core.info(`This pull request has a milestone set: ${data.milestone.title}`);
+            } else {
+              core.setFailed(`A maintainer needs to set the milestone for this pull request.`);
+            }

.github/workflows/ci_cron_weekly.yml

@@ -23,9 +23,9 @@ jobs:
     runs-on: ubuntu-latest
     if: (github.repository == 'spacetelescope/jdaviz' && (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'Extra CI')))
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
     - name: Set up Python to build docs with sphinx
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065  # v5.6.0
       with:
         python-version: '3.11'
     - name: Install base dependencies
@@ -41,11 +41,11 @@ jobs:
     if: (github.repository == 'spacetelescope/jdaviz' && (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'Extra CI')))
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
       with:
         fetch-depth: 0
     - name: Set up python
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065  # v5.6.0
       with:
         python-version: '3.11'
     - name: Install base dependencies
@@ -55,22 +55,23 @@ jobs:
     - name: Test with tox
       run: tox -e py311-test-devdeps-romandeps
 
-  ci_cron_tests_stable_roman:
-    name: Python 3.10 with stable versions of dependencies and Roman
+  ci_cron_tests_stable_strauss:
+    name: Python 3.12 with stable versions of dependencies and Strauss
     runs-on: ubuntu-latest
     if: (github.repository == 'spacetelescope/jdaviz' && (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'Extra CI')))
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
       with:
         fetch-depth: 0
     - name: Set up python
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065  # v5.6.0
       with:
-        python-version: '3.10'
+        python-version: '3.12'
     - name: Install base dependencies
       run: |
+        sudo apt-get install libportaudio2
         python -m pip install --upgrade pip
         python -m pip install tox
     - name: Test with tox
-      run: tox -e py310-test-romandeps
+      run: tox -e py312-test-straussdeps

.github/workflows/ci_workflows.yml

@@ -44,50 +44,94 @@ jobs:
             toxenv: securityaudit
             allow_failure: false
 
-          - name: Python 3.10 with coverage checking, all deps, and remote data
+          - name: Python 3.11 with coverage checking, all deps, and remote data
             os: ubuntu-latest
-            python: '3.10'
-            toxenv: py310-test-alldeps-cov
-            toxposargs: --remote-data
+            python: '3.11'
+            toxenv: py311-test-alldeps-cov
+            toxposargs: --remote-data --run-slow
             allow_failure: false
 
-          - name: OS X - Python 3.9
+          - name: OS X - Python 3.12
             os: macos-latest
-            python: 3.9
-            toxenv: py39-test
+            python: '3.12'
+            toxenv: py312-test
             allow_failure: false
 
-          - name: Windows - Python 3.9
+          - name: Windows - Python 3.12
             os: windows-latest
-            python: 3.9
-            toxenv: py39-test
+            python: '3.12'
+            toxenv: py312-test
+            allow_failure: false
+
+          - name: Linux - Python 3.13
+            os: ubuntu-latest
+            python: '3.13'
+            toxenv: py313-test
             allow_failure: false
 
           # This also runs on cron but we want to make sure new changes
           # won't break this job at the PR stage.
-          - name: Python 3.11 with latest dev versions of key dependencies, and remote data
+          - name: Python 3.13 with latest dev versions of key dependencies, and remote data
             os: ubuntu-latest
-            python: '3.11'
-            toxenv: py311-test-devdeps
+            python: '3.13'
+            toxenv: py313-test-devdeps
             toxposargs: --remote-data --run-slow
             allow_failure: true
 
+          - name: Python 3.11 with stable versions of dependencies and Roman
+            os: ubuntu-latest
+            python: '3.11'
+            toxenv: py311-test-romandeps
+            allow_failure: true
+
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
       with:
         fetch-depth: 0
     - name: Set up python ${{ matrix.python }} on ${{ matrix.os }}
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065  # v5.6.0
       with:
         python-version: ${{ matrix.python }}
     - name: Install base dependencies
       run: python -m pip install --upgrade pip tox
+    - name: Install extra dependencies for strauss
+      if: "contains(matrix.toxenv, 'alldeps')"
+      run: sudo apt-get install libportaudio2
+    - name: Get IP address for MAST debugging
+      if: "contains(matrix.toxposargs, '--remote-data')"
+      run: curl https://api.ipify.org
     - name: Test/run with tox
       run: tox -e ${{ matrix.toxenv }} -- ${{ matrix.toxposargs }}
-    - name: Upload coverage to codecov
+    - name: Upload coverage to artifacts
       if: "contains(matrix.toxenv, '-cov')"
-      uses: codecov/codecov-action@v3
+      uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4.6.2
+      with:
+        name: coverage_${{ matrix.toxenv }}.xml
+        path: coverage.xml
+        if-no-files-found: error
+
+  upload-codecov:
+    needs: [ ci_tests ]
+    permissions:
+      contents: none
+    runs-on: ubuntu-latest
+    name: Upload Coverage
+    steps:
+    # work around CodeCov upload issue
+    # see: https://github.com/codecov/codecov-action/issues/1801
+    - uses: actions/checkout@v4
+    - name: Download coverage artifacts
+      uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093  # v4.3.0
+      with:
+        path: coverage
+        pattern: coverage_*
+        merge-multiple: true
+    - name: Upload report to Codecov
+      if: ${{ hashFiles('coverage/') != '' }}
+      uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24  # v5.4.3
       with:
-        file: ./coverage.xml
+        token: ${{ secrets.CODECOV_TOKEN }}
+        directory: coverage
+        fail_ci_if_error: true
         verbose: true