Fix cyclic graph state explosion#191
Open
CapCap wants to merge 4 commits into
Open
Conversation
|
Thank you for creating this PR @CapCap |
|
Any time soon to have this fix on the codebase? Thanks |
Author
|
Unlikely, author believes this is a feature not a bug, despite performance quickly exponentially declining when used |
|
Ah I see! No worries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When states cycle A->B->A->B, there are a truly exponential number of states that get created. Two such cycles are enough to cause 10s + loading times for pages, and realistically will easily break altogether.
Big thank you to @JohnieBraaf for the fixes here.
This should fix #188
and #120
The problem is discussed in detail in the above issues.