Use the type system to improve sanitization while generating HTML for bbcode #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void script injections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces pull request #6. That fix was a band aid, so I looked into a way to make this more robust. Hence this new pull request.
Use the type system to help avoid XSS/script injection vulnerabilities. Introduces a new
SafeHtmltype string can only be constructed from:SafeHtmlstringsA
SafeHtmlstring cannot be constructed from unsanitized user input, and this is enforced by the type system. This is not a complete guarantee of safety against injection. You could specify "<script>" as a string literal and it would be considered safe. But this makes the code easier to audit.