Skip to content

Conversation

@catswe
Copy link

@catswe catswe commented Jan 25, 2026

Doc update while #34620 is being resolved

@google-cla
Copy link

google-cla bot commented Jan 25, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @catswe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides an important documentation update for the jnp.argmax and jnp.argmin functions within JAX. The primary goal is to inform users about a current discrepancy in behavior on Pallas TPU hardware, where the functions do not consistently return the smallest index when multiple maximum or minimum values are present. This clarification is a temporary measure while an underlying issue is being addressed, ensuring users are aware of the current operational specifics.

Highlights

  • Documentation Update: Updated the documentation for jnp.argmax and jnp.argmin to clarify their behavior on Pallas TPU when multiple occurrences of the maximum or minimum value exist.
  • Pallas TPU Specifics: Added a note indicating that the standard behavior of returning the smallest index for multiple identical values is currently not true on Pallas TPU for these functions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the docstrings for jnp.argmax and jnp.argmin to note a behavioral difference on Pallas TPU. The changes are good, but I've suggested making these notes more prominent by using a .. warning:: directive and including a link to the tracking issue for more context. This will help prevent users from being surprised by platform-specific behavior.

@catswe catswe changed the title Update jnp.argmin/argmax doc for Pallas TPU [Doc] Update jnp.argmin/argmax doc for Pallas TPU Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant