[WIP] Add support to dynamically set test deps for jax as an external repo #34641
+138
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekstheod
force-pushed
the
add_support_to_dynamic_set_of_test_deps
branch
from
fd616ab to
12afbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a possibility to inject test dependencies dynamically when including jax to an umbrella project.
e,g. --repo_env=EXTERNAL_TEST_DEPS=@jax_rocm_plugin//:pjrt.whl,@jax_rocm_plugin//:kernels.whl
This allows keeping clean the jax code itself but having needed deps at the same time to execute the tests under @jax