[Mosaic GPU] Enable column slicing for TMEM layouts with varying row dimensions.#38129
Open
copybara-service[bot] wants to merge 1 commit into
Open
[Mosaic GPU] Enable column slicing for TMEM layouts with varying row dimensions.#38129copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…dimensions. The TMEMRef slicing logic is updated to correctly handle column offsets when the base tile shape's row dimension differs from TMEM_ROWS. This involves scaling the column index by the row folding factor. I dropped the "partitioned across lanes or warps" check because I believe it is not relevant when slicing across tiles (i.e. column offset and slice shape are multiple of tile column size). PiperOrigin-RevId: 925327243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Mosaic GPU] Enable column slicing for TMEM layouts with varying row dimensions.
The TMEMRef slicing logic is updated to correctly handle column offsets when the base tile shape's row dimension differs from TMEM_ROWS. This involves scaling the column index by the row folding factor.
I dropped the "partitioned across lanes or warps" check because I believe it is not relevant when slicing across tiles (i.e. column offset and slice shape are multiple of tile column size).