Move dtypes.canonicalize_value to C++.#38171
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
Since this function is primarily "apply table of handlers", we can speed it up both by moving to C++ both: * the handler finding code, and * some of the most common handlers, notably the identity function. Notes: * We retain the ability to register handlers in Python for novel types. * We now want to call a weak key weak value cache from C++ when canonicalizing np.ndarray objects, so we add a C++ API for that also. * Since calling canonicalize_dtype is now faster than skipping it with a bunch of isinstance checks, we add a number of additional types (Tracer, ShapeDtypeStruct) to the set of things that canonicalize_value knowns how to handle and call it unconditionally in places like Primitive.bind(). PiperOrigin-RevId: 926256875
5bba5bd to
7f91bec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move dtypes.canonicalize_value to C++.
Since this function is primarily "apply table of handlers", we can speed it up both by moving to C++ both:
Notes: