Refactor float8 conversion logic. #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_843986627
branch
from
59653e4 to
e0d8bcc
Compare
This change completely rewrites the float8 conversion template to a more structured approach. It now explicitly handles special values (Inf/NaN), zero, unpacks and normalizes the input, calculates target parameters, applies rounding and shifting, renormalizes, and packs the result, including overflow and sign handling. The logic for handling subnormals and different exponent ranges between From and To types is integrated into this new flow. PiperOrigin-RevId: 845859579
copybara-service
bot
force-pushed
the
test_843986627
branch
from
e0d8bcc to
87ab443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor float8 conversion logic.
This change completely rewrites the float8 conversion template to a more structured approach. It now explicitly handles special values (Inf/NaN), zero, unpacks and normalizes the input, calculates target parameters, applies rounding and shifting, renormalizes, and packs the result, including overflow and sign handling. The logic for handling subnormals and different exponent ranges between From and To types is integrated into this new flow.