fix(memtemp-plus): handle missing cpu freq file and improve logging#13
Open
CoderFX wants to merge 2 commits intojayofelony:mainfrom
Open
fix(memtemp-plus): handle missing cpu freq file and improve logging#13CoderFX wants to merge 2 commits intojayofelony:mainfrom
CoderFX wants to merge 2 commits intojayofelony:mainfrom
Conversation
- Use .get() with defaults for 'scale' (default: celsius), 'orientation' (default: horizontal) to prevent KeyError when options are not set in config.toml - Initialize self.fields in __init__ to prevent AttributeError if on_unload is called before on_ui_setup - Bump version to 1.0.4
- Wrap cpu_freq() in try/except to gracefully handle missing scaling_cur_freq file (returns '?G' instead of crashing) - Add consistent [MemTemp-Plus] log prefix - Bump version to 1.0.5
CoderFX
force-pushed
the
fix/memtemp-plus-robustness
branch
from
54a76f9 to
05b36cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpu_freq()in try/except — returns?Ginstead of crashing if sysfs file is missing[MemTemp-Plus]log prefixBuilds on #12. Fixes #11.