Fix internet-connection: status never resets to disconnected#14
Open
CoderFX wants to merge 1 commit intojayofelony:mainfrom
Open
Fix internet-connection: status never resets to disconnected#14CoderFX wants to merge 1 commit intojayofelony:mainfrom
CoderFX wants to merge 1 commit intojayofelony:mainfrom
Conversation
- Fix status stuck on 'C' forever after first connection — added timeout-based disconnect detection via on_ui_update - Fix float position from ui.width() / 2 (use integer division) - Add configurable position and timeout via options - Add __init__, on_config_changed, on_loaded with .get() defaults - Remove unused subprocess import - Remove __name__ class attribute shadowing Python builtin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_ui_updatewith timeout-based disconnect detection (default 120s)ui.width() / 2— use integer division__init__,on_config_changed,on_loadedwith.get()defaultssubprocessimport__name__class attribute that shadows Python builtinConfig