Skip to content

codeorg: reduce dependency count for importers#454

Merged
jaypipes merged 2 commits into
jaypipes:mainfrom
sewnie:main
Apr 1, 2026
Merged

codeorg: reduce dependency count for importers#454
jaypipes merged 2 commits into
jaypipes:mainfrom
sewnie:main

Conversation

@sewnie

@sewnie sewnie commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

For any user of ghw, there is no reason to have to import a large testing library just to reduce a couple of lines of code, and to import cobra, which is a CLI package that should not be present in the dependency tree of a normal Go package.

@jaypipes

Copy link
Copy Markdown
Owner

@sewnie thanks for this contribution! go work didn't exist when ghw first started which is why this is an issue :)

I'll fix up the github workflows so that your CI jobs pass, but in the meantime, please sign your commits and force-push them back to the PR branch so that your Developer Certificate of Origin check passes.

Comment thread cmd/ghwc/go.mod Outdated
@@ -0,0 +1,10 @@
module github.com/jaypipes/ghw/cmd/ghwc

go 1.25.0

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this go 1.24 until I update the github workflow primary Go version for testing.

@jaypipes

Copy link
Copy Markdown
Owner

@sewnie also, if you'd like a higher bandwidth conversation about any of these issues/PRs, you can find me on Kubernetes Slack community, username jaypipes. :)

@jaypipes

Copy link
Copy Markdown
Owner

@sewnie CI pipelines are now fixed. Please rebase from main and re-push at your earliest convenience.

@sewnie

sewnie commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Actually increasing the version of Go was completely unnecessary. I really appreciate your fast response! Is it fine if i keep the same version in this PR?

@jaypipes jaypipes left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sewnie, all looks great :)

@jaypipes jaypipes merged commit 651a76e into jaypipes:main Apr 1, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants