Conversation
Make sure that everything is always in the correct pixel format
* Nested tables: post_process_tables ran pre-order (needed for width, which flows top-down), so an outer cell was sized before the table nested inside it was laid out — the cell stayed at its stale Taffy height and the inner table overflowed it (the HN logo poked out the bottom of the orange bar). Add a second, post-order pass and make layout_cell account for a contained nested table's height, so height propagates bottom-up. * Column sizing: a specified `width` could shrink a column below its content's min-width, clipping a wider image and eating the cell's padding. Use max(specified, min-content); include the image's full border-box width and the cell's own horizontal padding in the intrinsic content width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very specific fix for getting the hackernews logo [Y] rendered properly on the screen. It will fix more issues with other images, svg's and tables, but we focused on one specific image for now.