Re-drop dependency on typing_extensions
#269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it was only being used for `TypedDict`, which was added in Python 3.8 and `dj-database-url` v2.3.0+ only supports Python 3.9+. See: https://docs.python.org/3.12/library/typing.html#typing.TypedDict https://github.com/jazzband/dj-database-url/blob/master/CHANGELOG.md#v230-2024-10-23 Note: This is a repeat of jazzband#257, since that PR was lost as part of merges that occurred during the release of 3.0.0: jazzband#257 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 131 130 -1
Branches 14 14
=========================================
- Hits 131 130 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@palfrey @mattseymour Please could I have review/merge for this PR, which is a re-apply of #257, which appears to have been inadvertently overwritten during the merges for the recent 3.0.0 release? Thanks :-) |
Contributor
Author
|
@palfrey Thank you for the review/merge :-) I don't suppose you could release a v3.0.1 with this change? (Given the v3.0.0 GitHub releases item description says it's already shipped) |
Contributor
|
Released |
Contributor
Author
|
@mattseymour Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it was only being used for
TypedDict, which was added in Python 3.8 anddj-database-urlv2.3.0+ only supports Python 3.9+.See:
https://docs.python.org/3.12/library/typing.html#typing.TypedDict
https://github.com/jazzband/dj-database-url/blob/master/CHANGELOG.md#v230-2024-10-23
Note: This is a repeat of #257, since that PR was lost as part of merges that occurred during the release of 3.0.0:
#257 (comment)