Skip to content

optionally use select_related to pull related fields for old - #415

Draft
dgravitate wants to merge 3 commits into
jazzband:masterfrom
dgravitate:master
Draft

optionally use select_related to pull related fields for old#415
dgravitate wants to merge 3 commits into
jazzband:masterfrom
dgravitate:master

Conversation

@dgravitate

Copy link
Copy Markdown
Member

Add the ability to use select_related to pull related fields when getting the old instance to compare against. This should eliminate some unnecessary queries and boost performance, particularly when dealing with lots of related fields.

@codecov

codecov Bot commented Aug 15, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.01%. Comparing base (a00d2c2) to head (b8d6dab).
⚠️ Report is 204 commits behind head on master.

Files with missing lines Patch % Lines
auditlog/receivers.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   91.79%   91.01%   -0.78%     
==========================================
  Files          23       23              
  Lines         646      657      +11     
==========================================
+ Hits          593      598       +5     
- Misses         53       59       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hramezani

Copy link
Copy Markdown
Member

Thanks @dgravitate for the patch 👍

I haven't looked in detail at the patch. but you need:

@dgravitate
dgravitate marked this pull request as draft August 17, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants