Remove first_name / last_name from admin if missing from model

[silviogutierrez]

Closes #509

This is a "static" approach, which I think is better than overriding get_search_fields. I believe the get_* methods are for truly dynamic behavior (based on the request, the current user, etc). With this, admin checks will still apply (though not particularly useful).

[codecov]

Codecov Report

Merging #512 (01ac6ec) into master (fcb6c4c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   94.22%   94.24%   +0.01%     
==========================================
  Files          30       30              
  Lines         900      903       +3     
==========================================
+ Hits          848      851       +3     
  Misses         52       52              

Impacted Files	Coverage Δ
auditlog/admin.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[hramezani]

@silviogutierrez Thanks for this path.

As I mention in the issue, overriding the get_search_fields would be a better approach. please implement it like this.
Also, you need to add some tests and a changelog entry in https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md

[RomHartmann]

How about something like the following, which adds whichever field is available, handling the case where either fist_name or last_name do actually exist

    search_fields = [
        "timestamp",
        "object_repr",
        "changes",
        f"actor__{get_user_model().USERNAME_FIELD}",
    ] + [f"actor__{f.name}" for f in get_user_model()._meta.get_fields() if f.name in ["first_name", "last_name"]]

[hramezani]

This is better because includes whatever fields that are available.
Feel free to create a new PR with tests and changelog

[twkrol]

Hi. Any progress planned for this issue?
It really prevents me from using search which results in big difficulty to get facts from the logs.

[hramezani]

The approach of this PR should be changed.
Also test and change log has to be included.

BTW, you can create your custom admin inherited from LogEntryAdmin and implement your desired get_search_fields to unblock yourself or even better create a new PR and fix it for the library