Skip accessing request.user if the session is empty - #839
Open
gvangool wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 96.33% 96.34%
=======================================
Files 35 35
Lines 1256 1259 +3
=======================================
+ Hits 1210 1213 +3
Misses 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Accessing `request.user` would automatically mark the current session as accessed and set a `Vary: Cookie` header on the response. This happens *even* when `request.user` is empty.
gvangool
force-pushed
the
fix/accessing-empty-session
branch
from
July 28, 2026 19:58
dd15c39 to
6f2a46e
Compare
gvangool
changed the title
gvangool
force-pushed
the
fix/accessing-empty-session
branch
from
July 28, 2026 20:03
6f2a46e to
85775ed
Compare
gvangool
marked this pull request as ready for review
July 28, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing
request.userwould automatically mark the current session as accessed and set aVary: Cookieheader on the response. This happens even whenrequest.useris the anonymous user.