remove dependency on unicode-slugify, use Django builtin function #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrDlouhy
force-pushed
the
remove_slugify_dependency
branch
2 times, most recently
from
ee6f28d to
99b30a8
Compare
|
@coordt @sinasamavati Could you remember more closely why the I have added a test with some testing strings in this PR. All of them seems to have the same result as before, but I would be glad if you could suggest more of them. |
|
It was long ago, but I think it was to support Cyrillic alphabets or fix issues with Cyrillic slugs' romanization. |
PetrDlouhy
force-pushed
the
remove_slugify_dependency
branch
from
99b30a8 to
347b842
Compare
PetrDlouhy
force-pushed
the
remove_slugify_dependency
branch
from
347b842 to
61ad474
Compare
|
OK, thanks. I have added the Greek cyrilic to the testing strings. The output seems to be consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
django.utils.text.slugifywithallow_unicode=Trueand removeunicode-slugifydependency (which causes conflicts withpython-slugifyand seems to be unnecessary.