Skip to content

Fix interaction with procrastinate #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix interaction with procrastinate #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions configurations/importer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@ def install(check_options=False):
orig_create_parser = base.BaseCommand.create_parser

def create_parser(self, prog_name, subcommand):
# Since some subclasses of BaseCommand, procrastinate's in particular, assume that all
# but their own arguments are already defined when add_arguments is called, we're
# temporarily swapping it out for a no-op and call it later.
add_arguments = self.add_arguments
self.add_arguments = lambda *a, **k: None
parser = orig_create_parser(self, prog_name, subcommand)

if isinstance(parser, OptionParser):
# in case the option_list is set the create_parser
# will actually return a OptionParser for backward
Expand All @@ -43,6 +49,9 @@ def create_parser(self, prog_name, subcommand):
# probably argparse, let's not import argparse though
parser.add_argument(CONFIGURATION_ARGUMENT,
help=CONFIGURATION_ARGUMENT_HELP)

self.add_arguments = add_arguments
self.add_arguments(parser)
return parser

base.BaseCommand.create_parser = create_parser
Expand Down