Update CI: Add Django 5.2, drop Python 3.7#214
Update CI: Add Django 5.2, drop Python 3.7#214mahdirahimi1999 wants to merge 16 commits intojazzband:masterfrom
Conversation
…o backend tests This test was not required and has been removed to clean up the test suite.
|
@mgrdcm @aleksihakli could you please take a look at this whenever you get a chance? |
|
I imagine this isn't getting reviews because people aren't ready to untangle such a huge change that mixes, formatting, refactoring and multiple unrelated functional changes. If I were you, I'd send incremental changes in small chunks. |
Thank you for your candid response. I've re-done some of these changes in #215, where it is more obvious what is going on, to the extent possible, that is. This CI breakage (GitHub moves fast and breaks things indeed) turned into somewhat of a Gordian knot so it's either accepting a PR with a non-trivial amount of changes or accepting multiple in which CI still wouldn't work in each of them. If you can think of some yet better approach, that, too, would be very much appreciated. |
|
As mentioned, I can't merge this as the required Python 3.7 / Django 3.2 check is not passing after the changes. |
Thank you! Can you please clarify where you're going with this? Going off the assumption that you're OK with this being merged, how do we reach somebody who can do an override? Otherwise, if you're requesting that we re-enable Python 3.7 tests, that's a tough order because that version isn't supported by the GitHub framework anymore. |
I’m ok with the merge if e.g. @jezdez or someone else can disable or override the checks or someone else figures out a workaround. |
You should be able to get it on an older Ubuntu for that job. Alternatively, use deadsnakes, uv or a Fedora container.. |
Thanks for the |
|
Hey @mahdirahimi1999! Master and tests should be fixed now, would you be able to rebase this on top of the new master branch? Python 3.7 support can be left to be. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 99.10% 99.11%
=======================================
Files 16 16
Lines 671 676 +5
Branches 40 39 -1
=======================================
+ Hits 665 670 +5
Misses 4 4
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add Django 5.2, update black/isort, fix Python 3.7 compatibility
e6b7cc9 to
c3a135b
Compare
|
Hey @aleksihakli, |
Done |
What’s new
Django 5.2 support
setup.pyclassifierstox.inienvironmentsCI improvements
checkout→ v4setup-python→ v5cache→ v4codecov→ v4set-outputwithGITHUB_OUTPUTtox.iniblack→>=24.1.1isort→>=5.13.2-t py38fromblack(now inferred from code)Test stability
Why remove Python 3.7?
Current test matrix
This ensures full coverage of supported versions with modern tooling and reliable tests.