Skip to content

Update CI: Add Django 5.2, drop Python 3.7#214

Closed
mahdirahimi1999 wants to merge 16 commits intojazzband:masterfrom
mahdirahimi1999:enhancement/ci-django-5.2
Closed

Update CI: Add Django 5.2, drop Python 3.7#214
mahdirahimi1999 wants to merge 16 commits intojazzband:masterfrom
mahdirahimi1999:enhancement/ci-django-5.2

Conversation

@mahdirahimi1999
Copy link
Member

@mahdirahimi1999 mahdirahimi1999 commented Jun 27, 2025

What’s new

  • Django 5.2 support

    • Added to GitHub Actions test matrix
    • Added to setup.py classifiers
    • Added to tox.ini environments
  • CI improvements

    • Updated GitHub Actions versions:
      • checkout → v4
      • setup-python → v5
      • cache → v4
      • codecov → v4
    • Replaced deprecated set-output with GITHUB_OUTPUT
    • Dropped Python 3.7 support from test matrix and tox.ini
    • Updated linting tools:
      • black>=24.1.1
      • isort>=5.13.2
      • Removed -t py38 from black (now inferred from code)
  • Test stability

    • Improved Vimeo thumbnail URL test:
      • Now compares only scheme, domain, and path (ignores query params)

Why remove Python 3.7?

  • Python 3.7 reached end-of-life on June 27, 2023
  • GitHub Actions no longer supports Python 3.7 on Ubuntu 24.04
  • Attempting to use 3.7 in CI results in environment resolution errors
  • Django 3.2 (LTS) is still tested with Python 3.8+, so there’s no compatibility loss

Current test matrix

  • Python: 3.8, 3.9, 3.10, 3.11, 3.12
  • Django: 3.2, 4.1, 4.2, 5.0, 5.1, 5.2

This ensures full coverage of supported versions with modern tooling and reliable tests.

@mahdirahimi1999 mahdirahimi1999 requested review from aleksihakli, hramezani and mgrdcm and removed request for hramezani and mgrdcm June 27, 2025 14:42
@jemmix
Copy link

jemmix commented Jul 23, 2025

@mgrdcm @aleksihakli could you please take a look at this whenever you get a chance?

@webknjaz
Copy link
Member

webknjaz commented Sep 1, 2025

I imagine this isn't getting reviews because people aren't ready to untangle such a huge change that mixes, formatting, refactoring and multiple unrelated functional changes.

If I were you, I'd send incremental changes in small chunks.

@jemmix
Copy link

jemmix commented Sep 1, 2025

I imagine this isn't getting reviews because people aren't ready to untangle such a huge change that mixes, formatting, refactoring and multiple unrelated functional changes.

If I were you, I'd send incremental changes in small chunks.

Thank you for your candid response. I've re-done some of these changes in #215, where it is more obvious what is going on, to the extent possible, that is. This CI breakage (GitHub moves fast and breaks things indeed) turned into somewhat of a Gordian knot so it's either accepting a PR with a non-trivial amount of changes or accepting multiple in which CI still wouldn't work in each of them. If you can think of some yet better approach, that, too, would be very much appreciated.

@aleksihakli
Copy link
Member

As mentioned, I can't merge this as the required Python 3.7 / Django 3.2 check is not passing after the changes.

@jemmix
Copy link

jemmix commented Oct 13, 2025

As mentioned, I can't merge this as the required Python 3.7 / Django 3.2 check is not passing after the changes.

Thank you! Can you please clarify where you're going with this? Going off the assumption that you're OK with this being merged, how do we reach somebody who can do an override? Otherwise, if you're requesting that we re-enable Python 3.7 tests, that's a tough order because that version isn't supported by the GitHub framework anymore.

@aleksihakli
Copy link
Member

Thank you! Can you please clarify where you're going with this? Going off the assumption that you're OK with this being merged, how do we reach somebody who can do an override? Otherwise, if you're requesting that we re-enable Python 3.7 tests, that's a tough order because that version isn't supported by the GitHub framework anymore.

I’m ok with the merge if e.g. @jezdez or someone else can disable or override the checks or someone else figures out a workaround.

@webknjaz
Copy link
Member

Python 3.7 tests, that's a tough order because that version isn't supported by the GitHub framework anymore.

You should be able to get it on an older Ubuntu for that job. Alternatively, use deadsnakes, uv or a Fedora container..

@mgrdcm
Copy link
Member

mgrdcm commented Feb 3, 2026

Python 3.7 tests, that's a tough order because that version isn't supported by the GitHub framework anymore.

You should be able to get it on an older Ubuntu for that job. Alternatively, use deadsnakes, uv or a Fedora container..

Thanks for the deadsnakes recommendation @webknjaz! I did that in another PR: ed8fbcb

@aleksihakli
Copy link
Member

Hey @mahdirahimi1999! Master and tests should be fixed now, would you be able to rebase this on top of the new master branch? Python 3.7 support can be left to be.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (21fa058) to head (c3a135b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   99.10%   99.11%           
=======================================
  Files          16       16           
  Lines         671      676    +5     
  Branches       40       39    -1     
=======================================
+ Hits          665      670    +5     
  Misses          4        4           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mahdirahimi1999 mahdirahimi1999 force-pushed the enhancement/ci-django-5.2 branch from e6b7cc9 to c3a135b Compare February 7, 2026 10:57
@mahdirahimi1999
Copy link
Member Author

Hey @aleksihakli,
Rebased on master, Python 3.7 kept, Django 5.2 added. Should be good to go now.

@mahdirahimi1999
Copy link
Member Author

Hey @mahdirahimi1999! Master and tests should be fixed now, would you be able to rebase this on top of the new master branch? Python 3.7 support can be left to be.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments