Skip to content

test: improve Vimeo thumbnail URL assertion by ignoring query params #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgrdcm wants to merge 4 commits into
base: master
Choose a base branch
from
Open

test: improve Vimeo thumbnail URL assertion by ignoring query params #228

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2d5d6c
test: improve Vimeo thumbnail URL assertion by ignoring query params
mahdirahimi1999 Jun 12, 2025
9407fd5
Fix `isort` issue
mgrdcm Feb 13, 2026
41c78da
Fix `black` formatting error
mgrdcm Feb 13, 2026
2ffdee1
Merge branch 'master' into vimeo-test-parts
mgrdcm Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions embed_video/tests/backends/tests_vimeo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import urllib.parse
from unittest import TestCase
from unittest.mock import patch

Expand Down Expand Up @@ -39,9 +40,17 @@ def test_vimeo_get_info_exception(self):

def test_get_thumbnail_url(self):
backend = VimeoBackend("https://vimeo.com/72304002")
expected_url = "https://i.vimeocdn.com/video/446150690-9621b882540b53788eaa36ef8e303d4e06fc40af3d27918b7f561bb44ed971dc-d_640"
actual_url = backend.get_thumbnail_url()

# Parse URLs and compare without query parameters
expected_parts = urllib.parse.urlparse(expected_url)
actual_parts = urllib.parse.urlparse(actual_url)

# Compare scheme, netloc, and path only
self.assertEqual(
backend.get_thumbnail_url(),
"https://i.vimeocdn.com/video/446150690-9621b882540b53788eaa36ef8e303d4e06fc40af3d27918b7f561bb44ed971dc-d_640?region=us",
(expected_parts.scheme, expected_parts.netloc, expected_parts.path),
(actual_parts.scheme, actual_parts.netloc, actual_parts.path),
)

@patch("embed_video.backends.EMBED_VIDEO_TIMEOUT", 0.000001)
Expand Down
Loading