Open
Conversation
Contributor
|
Is there a reason that this PR has not been merged? Tests are passing and I don't see any discussion. |
Author
|
+1 |
Contributor
|
I don't see any tests nor documentation about the new functionality. These are required. |
| # contains a valid step name. If one was found, render the requested | ||
| # form. (This makes stepping back a lot easier). | ||
| wizard_goto_step = self.request.POST.get('wizard_goto_step', None) | ||
| wizard_goto_step = getattr(self.request, self.form_method).get('wizard_goto_step', None) |
There was a problem hiding this comment.
I'm a bit confused as to how this is supposed to work. By ignoring the actual request.method and forcing the use of self.form_method here an in the next couple of places it is used, isn't the code saying that ALL form interaction can only use self.form_method? Specifically, stepping forward and the final submit cannot use a POST if self.form_method is set to 'GET'.
Or have I not understood the purpose of self.form_method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using "get" as a form method for users who don't want to or can't use default "post".