Conversation
|
Thanks for the contrib. This is quite the feature and I'm quite loaded with work right now. Please bear with me that it might take up to several months for us to properly review this and get back to you. In the mean time, the PR will stay open so others are able to use it and (hereby) are also explicitly invited to give feedback! Of particular interest to me is to assure that:
|
|
Not sure if I'll find time, but for better chances, the patch should also be stripped from layout and convenience changes. @ptitloup, only change what is required for the new functionality. Then you can suggest formatting changes in a separate patch if you want. |
…subscrided to newsletter group
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('auth', '0008_alter_user_username_max_length'), |
There was a problem hiding this comment.
This is an unrelated migration - please remove it from this PR
|
|
||
| dependencies = [ | ||
| ('auth', '0008_alter_user_username_max_length'), | ||
| ('newsletter', '0004_auto_20180407_1043'), |
There was a problem hiding this comment.
Can you please create a completely new migration based from the current master?
| my_urls.append(url(r'^jsi18n/$', | ||
| JavaScriptCatalog.as_view(packages=('newsletter',)), | ||
| name='newsletter_js18n')) | ||
| JavaScriptCatalog.as_view( |
There was a problem hiding this comment.
Please rebase on current master (this was fixed slightly different in another PR)
newearthmartin
force-pushed
the
master
branch
7 times, most recently
from
716b4d8 to
e48481c
Compare
newearthmartin
force-pushed
the
master
branch
2 times, most recently
from
87e32e0 to
7071815
Compare
5 participants
I created this branch to add owner group(s) to newsletter. If newsletter have group(s), only users of this groups (and superuser) can manage it and his messages, subscription and submision...
Newsletter groups are not required, it doesn't change anything if you don't want to use it.
Please let me know if it contains mistakes.
Regards