Skip to content

use path in urls #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2024
Merged

use path in urls #1456

merged 5 commits into from
Aug 14, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 14, 2024

Description of the Change

This PR replaces re_path with simple, straightforward path, removing unnecessary regex.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk
Copy link
Member

n2ygk commented Aug 14, 2024

Hi @dulmandakh,

Please update the checklist and also explain why this PR is necessary. is replacing re_path() with path() worth the effort? Thanks.

@dulmandakh
Copy link
Contributor Author

Hi @dulmandakh,

Please update the checklist and also explain why this PR is necessary. is replacing re_path() with path() worth the effort? Thanks.

Hi. Updated checklist and added brief explanation.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Always nice to make the code more readable.

@n2ygk n2ygk merged commit 2a5845d into jazzband:master Aug 14, 2024
27 checks passed
@dulmandakh dulmandakh deleted the use-path-urls branch August 15, 2024 14:10
@n2ygk n2ygk added this to the 3.0.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants