Skip to content

Make pytz optional #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Make pytz optional #1458

merged 4 commits into from
Aug 15, 2024

Conversation

9128305
Copy link
Contributor

@9128305 9128305 commented Aug 15, 2024

Description of the Change

Pytz should be an optional dependency.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk added this to the 3.0.0 milestone Aug 15, 2024
@n2ygk
Copy link
Member

n2ygk commented Aug 15, 2024

You will need to rebase this as master has recent PRs merged in.

@9128305
Copy link
Contributor Author

9128305 commented Aug 15, 2024

Are you squashing merge requests? I could update without manually rebasing

@n2ygk
Copy link
Member

n2ygk commented Aug 15, 2024

Are you squashing merge requests? I could update without manually rebasing

Yes.

@9128305
Copy link
Contributor Author

9128305 commented Aug 15, 2024

Done.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@n2ygk n2ygk merged commit 56149aa into jazzband:master Aug 15, 2024
20 checks passed
@9128305 9128305 deleted the patch-1 branch August 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants