Stop stripe provider from setting refund status directly#476
Open
YounesOMK wants to merge 1 commit intojazzband:mainfrom
Open
Stop stripe provider from setting refund status directly#476YounesOMK wants to merge 1 commit intojazzband:mainfrom
YounesOMK wants to merge 1 commit intojazzband:mainfrom
Conversation
YounesOMK
commented
Mar 9, 2026
| provider.refund(payment) | ||
|
|
||
| assert payment.status == PaymentStatus.REFUNDED | ||
| assert payment.status == PaymentStatus.CONFIRMED |
Author
There was a problem hiding this comment.
this assertion is not really needed since were just checking the provider doesn't touch the status because its role is to just do the api call, but i think its a nice guard in case someone adds change_status back in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed premature change_status(REFUNDED) from stripe provider,
BasePayment.refund() already handles this (same as cybersource/dummy providers).
Fixes #475