Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-level select_related #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

One-level select_related #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion polymorphic/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,21 @@ class self.model, but as a class derived from self.model. We want to re-fetch
**{("%s__in" % pk_name): idlist}
)
# copy select related configuration to new qs
real_objects.query.select_related = self.query.select_related

if self.query.select_related is False:
real_objects.query.select_related = False
else:
concrete_model_name = real_concrete_class._meta.model_name
sub_model_names = set([m._meta.model_name for m in self.model.__subclasses__()])
sub_model_names.remove(concrete_model_name)

for sub_name in sub_model_names:
self.query.select_related.pop(sub_name, None)

if concrete_model_name in self.query.select_related:
real_objects.query.select_related = self.query.select_related[concrete_model_name]
else:
real_objects.query.select_related = self.query.select_related

# Copy deferred fields configuration to the new queryset
deferred_loading_fields = []
Expand Down