Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5.1+ compatibility for PolymorphicQuerySet._process_aggregate_args() #629

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Django 5.1+ compatibility for PolymorphicQuerySet._process_aggregate_args() #629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc5095
Django 5.1+ compatibility for Query._process_aggregate_args()
LeGast00n Mar 16, 2025
89d5f4b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions polymorphic/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,9 @@ def patch_lookup(a):
def test___lookup(a):
"""*args might be complex expressions too in django 1.8 so
the testing for a '___' is rather complex on this one"""
if a is None:
return # since Django v5.1, get_source_expressions() return can have None in its items

if isinstance(a, Q):

def tree_node_test___lookup(my_model, node):
Expand Down