feat : add 'hset, hdel' interfaces#618
Open
moonseoklee wants to merge 29 commits intojazzband:masterfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
========================================
- Coverage 83.3% 83.3% -0.0%
========================================
Files 21 21
Lines 1043 1102 +59
========================================
+ Hits 868 917 +49
- Misses 175 185 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
add - changelog.d
…go-redis into hash-set-delete # Conflicts: # django_redis/client/default.py
for more information, see https://pre-commit.ci
…go-redis into hash-set-delete # Conflicts: # django_redis/client/default.py
for more information, see https://pre-commit.ci
…go-redis into hash-set-delete # Conflicts: # django_redis/client/default.py
for more information, see https://pre-commit.ci
…go-redis into hash-set-delete # Conflicts: # django_redis/client/default.py
for more information, see https://pre-commit.ci
WisdomPill
requested changes
Sep 6, 2022
Member
WisdomPill
left a comment
WisdomPill
left a comment
There was a problem hiding this comment.
where are the tests?
without tests we can't merge anything
…go-redis into hash-set-delete # Conflicts: # django_redis/client/default.py
for more information, see https://pre-commit.ci
…go-redis into hash-set-delete # Conflicts: # django_redis/client/default.py
Author
|
I wrote tests |
for more information, see https://pre-commit.ci
…go-redis into hash-set-delete # Conflicts: # django_redis/client/default.py
for more information, see https://pre-commit.ci
…go-redis into hash-set-delete
for more information, see https://pre-commit.ci
|
@moonseoklee are you looking for help to close this one? |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface corresponding to hset, hdel of redis-py has been created.
issue #373