Passing username to redis arguments

[joachimBurket]

resolves #656

[WisdomPill]

thanks for the contribution! it would be nice to have a test for this and a change log file

[WisdomPill]

I would keep both examples if they work

[joachimBurket]

I merged the example in which the username is passed in the URL and the password in the OPTIONS with the example of a URL unsafe password, because I thought it was redundant. Tell me if it suits you as done in 039432c

[joachimBurket]

I added the changelog and a test. I wasn't sure where to test the connection params so I renamed the test_connection_string.py file in test_connection_params.py and added it there with the test of the URL.

[joachimBurket]

ping ;)

[WisdomPill]

I would love to have tests to connect to a server with credentials

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 56.3%. Comparing base (9d572cd) to head (fc3fd6c).
Report is 172 commits behind head on master.

Files	Patch %	Lines
tests/test_connection_params.py	33.4%	18 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #657     +/-   ##
========================================
- Coverage    57.5%   56.3%   -1.1%     
========================================
  Files          39      39             
  Lines        2528    2546     +18     
  Branches       75      74      -1     
========================================
- Hits         1452    1432     -20     
- Misses       1059    1097     +38     
  Partials       17      17             

Flag	Coverage Δ
mypy	33.7% <30.0%> (-0.1%)	⬇️
tests	83.6% <100.0%> (-<0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Adrian-at-CrimsonAzure]

I would really like to see this make it into a release, I can help get it over the line if help is needed.

[joachimBurket]

Yeaaaah it's been a while sorry 😅
@WisdomPill I'm not sure how the missing tests should be implemented, could you add some precision on this?