Issue #598 extend support for the hashmap functions#746
Issue #598 extend support for the hashmap functions#746rootart wants to merge 1 commit intojazzband:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
========================================
+ Coverage 63.3% 64.3% +1.1%
========================================
Files 43 43
Lines 3215 3389 +174
Branches 244 287 +43
========================================
+ Hits 2034 2179 +145
- Misses 1164 1192 +28
- Partials 17 18 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WisdomPill
left a comment
There was a problem hiding this comment.
looks great, but please add versioning in another PR so that it can be also tested separately
| def test_hsetnx(self, cache: RedisCache): | ||
| result_foo1 = cache.hsetnx("foo_hash1", "foo1", "bar1") | ||
| result_foo2 = cache.hsetnx("foo_hash1", "foo2", "bar2") | ||
| result_foo2_1 = cache.hsetnx("foo_hash1", "foo2", "bar2") |
There was a problem hiding this comment.
could you change the value written?
| result_foo2_1 = cache.hsetnx("foo_hash1", "foo2", "bar2") | |
| result_foo2_1 = cache.hsetnx("foo_hash1", "foo2", "bar3") |
|
@rootart do you have time to finish this PR? otherwise I can take it... that said, thanks for the effort you've put in this project so far, it is highly appreciated 😄 |
|
I'm happy to come back and continue some work on the PR 😄
Would you suggest deleting versioning, even in the newly added interfaces? There is definitely a dependency on the |
|
It seems like some work is duplicated; could you please take a look at my PR as well? @rootart @WisdomPill |
No description provided.