Fix RedisCache.close() to check for client before closing.#796
Open
wloggains-mmllc wants to merge 6 commits intojazzband:masterfrom
Open
Fix RedisCache.close() to check for client before closing.#796wloggains-mmllc wants to merge 6 commits intojazzband:masterfrom
wloggains-mmllc wants to merge 6 commits intojazzband:masterfrom
Conversation
… add-check-rediscache-close
Co-authored-by: Javier Buzzi <buzzi.javier@gmail.com>
kingbuzzman
approved these changes
Oct 20, 2025
for more information, see https://pre-commit.ci
|
@WisdomPill hey is there anything else you'd like to see? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are some situations where the
_clientin RedisCache is not instantiated when theclose()method is called. We have ran into this specifically with django.core.cache.CacheHandler.close_caches(). While it does not cause an error, it is an inefficiency.Solution
This pull request makes an update to
django_redis/cache.py::RedisCache.close()to prevent unnecessary initialization of the_client.The close method now checks if
_client is not Nonebefore attempting to close the client.I have also added a test.