Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #809 +/- ##
========================================
- Coverage 38.2% 38.1% -0.0%
========================================
Files 48 48
Lines 3727 3879 +152
Branches 301 335 +34
========================================
+ Hits 1420 1476 +56
- Misses 2006 2068 +62
- Partials 301 335 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
…django-redis into fixing_failed_test
Member
|
why so many new methods were added? |
WisdomPill
reviewed
Dec 23, 2025
| def patch_itersize_setting() -> Iterable[None]: | ||
| # destroy cache to force recreation with overriden settings | ||
| del caches["default"] | ||
| with suppress(AttributeError): |
Member
There was a problem hiding this comment.
perhaps this should be solved somehow different? why is it needed? which Django version introduced this error?
WisdomPill
reviewed
Dec 23, 2025
| value = int(value) | ||
| except (ValueError, TypeError): | ||
| with suppress(ValueError, TypeError): | ||
| return float(value) |
Member
There was a problem hiding this comment.
we do not have incrbyfloat, why add it to hash commands?
Member
|
I would have added separately the changes, this is not just a fix |
Author
I was trying to solve this : #766 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #808
Trying to fix the failed test in CI